more info on sizehint! #47235
Merged
more info on sizehint! #47235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO, the
sizehint!info isn't complete in some way, since its not quite evident at the onset how this "can improve performance", so it would be best to provide a few info on how it actually does the "improves performance". The motivation was gotten far back from this conversation on https://groups.google.com/g/julia-users/c/214uuJcCF6o aboutsizehint!, and as you can see there, the words I added in this PR are @StefanKarpinski's own.Also from an issue here #5364, it was evident using
resize!in some cases might actually be the "best use-case", as was suggested to the user by @JeffBezanson, so I think it would be great to add asee alsosection for this. I'm not quite verse in this, so it would be great to see people who know a lot on this improve thesee alsosection, as "improves performance" is still a well-known debatable issue withsizehint!(some great PRs and issue-solvers are currently opened on this).