Test return typeassert on inner constructor is respected #47227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please make titles and commit messages describe the fix itself; the #s should only go into the body for cross-referencing and auto-closing |
jakobnissen
force-pushed
the
test47209
branch
from
001964d to
baff8be
Compare
jakobnissen
changed the title
|
Alright, done. |
KristofferC
added
test
On Julia 1.8, if the internal constructor's return value was typeasserted,
this assertion could be violated without an error. For example, in this case:
```julia
struct Foo
x::Int
Foo()::Nothing = new(1)
end
```
Running `Foo()` would not throw. This was inadvertently fixed in a later PR,
but not tested.
This PR adds a test case similar to the example above.
DilumAluthge
force-pushed
the
test47209
branch
from
baff8be to
ea59fe1
Compare
|
CI errors appear unrelated |
DilumAluthge
removed
the
merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that #47209 remains fixed.