optimizer: simplify inlining algorithm #47207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
aviatesk
changed the title
aviatesk
force-pushed
the
avi/simplify-inlining
branch
2 times, most recently
from
787c127 to
481d121
Compare
|
@nanosoldier |
aviatesk
added
the
compiler:optimizer
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
|
Okay, better performance. This should be ready. |
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
aviatesk
changed the title
The main purpose of this commit is to try to simplify our inlining algorithm by removing the delayed callee resolving mechanism (i.e. `DelayedInliningSpec` stuff), since that kind of mechanism currently has no users and we provide more fine grained control with `inlining_policy` now. This commit also adds some more cleanups, changing argument ordering of some subroutines so that they are aligned with the other ones, and removing dead subroutines.
aviatesk
force-pushed
the
avi/simplify-inlining
branch
from
481d121 to
74de264
Compare
|
@nanosoldier |
|
Your benchmark job has completed - no performance regressions were detected. A full report can be found here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this commit is to try to simplify our inlining
algorithm by removing the delayed callee resolving mechanism (i.e.
DelayedInliningSpecstuff), since that kind of mechanism currentlyhas no users and we provide more fine grained control with
inlining_policynow.This commit also adds some more cleanups, changing argument ordering of
some subroutines so that they are aligned with the other ones, and
removing dead subroutines.