Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement jl_rec_backtrace for ASM/SETJMP on FreeBSD #47156

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Conversation

ararslan
Copy link
Member

This removes the message emitted while compiling on FreeBSD that says it isn't supported.

That said, while the code compiles without issue, I'm not certain it's actually correct. It seems jl_rec_backtrace is only used in jlbacktracet, which is listed among the GDB utilities, so perhaps GDB (or LLDB?) could be used to check against the result on another system. I'd just need some guidance for how to do so as I'm generally unfamiliar with this part of the code.

This removes the message emitted while compiling on FreeBSD that says it
isn't supported.
@ararslan ararslan added the system:freebsd Affects only FreeBSD label Oct 13, 2022
@ararslan
Copy link
Member Author

I've been trying to exercise this code path but I can't quite get there. The closest I've come is

@async begin
    try
        error("bad")
    catch
        ccall(:jlbacktracet, Cvoid, (Any,), current_task())
    end
end

which at least shows jl_rec_backtrace.

@vtjnash vtjnash merged commit 3144a5b into master Oct 14, 2022
@vtjnash vtjnash deleted the aa/bsd-setjmp branch October 14, 2022 20:15
@ararslan
Copy link
Member Author

I assume this looks correct enough then 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system:freebsd Affects only FreeBSD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants