pass around CallInfo object to the inlining algorithm [alternative]
#46965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
aviatesk
force-pushed
the
avi/callinfo
branch
from
fb34f00 to
e1fc60b
Compare
aviatesk
force-pushed
the
avi/custom-inlining2
branch
from
05324df to
06a0ceb
Compare
|
@nanosoldier |
aviatesk
force-pushed
the
avi/custom-inlining2
branch
from
06a0ceb to
f0b5872
Compare
aviatesk
changed the title
CallInfo object to the inlining algorithm [alternative]CallInfo object to the inlining algorithm [alternative]
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
|
@nanosoldier |
|
Your job failed. |
aviatesk
force-pushed
the
avi/callinfo
branch
from
e1fc60b to
12cd627
Compare
aviatesk
force-pushed
the
avi/custom-inlining2
branch
from
f0b5872 to
e323983
Compare
aviatesk
force-pushed
the
avi/callinfo
branch
from
12cd627 to
4d2f51e
Compare
aviatesk
force-pushed
the
avi/custom-inlining2
branch
2 times, most recently
from
3e19d27 to
fa40a20
Compare
aviatesk
force-pushed
the
avi/custom-inlining2
branch
from
fa40a20 to
4ac1d6e
Compare
|
@nanosoldier |
aviatesk
force-pushed
the
avi/custom-inlining2
branch
from
4ac1d6e to
bddc70f
Compare
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
aviatesk
force-pushed
the
avi/custom-inlining2
branch
from
bddc70f to
506b63c
Compare
aviatesk
force-pushed
the
avi/custom-inlining2
branch
from
506b63c to
facfa9e
Compare
aviatesk
force-pushed
the
avi/custom-inlining2
branch
from
facfa9e to
ad679f3
Compare
aviatesk
force-pushed
the
avi/custom-inlining2
branch
from
ba06a77 to
ad679f3
Compare
aviatesk
force-pushed
the
avi/custom-inlining2
branch
from
ad679f3 to
076de76
Compare
So that `inlining_policy` can see user-`CallInfo` object. It allows us to implement a customized inlining heuristics by just seeing a callsite information, without requiring the inlining cost of cached code to be tweaked.
aviatesk
force-pushed
the
avi/custom-inlining2
branch
from
076de76 to
8e97c45
Compare
aviatesk
added a commit
to JuliaDebug/Cthulhu.jl
that referenced
this pull request
Oct 7, 2022
aviatesk
added a commit
to JuliaDebug/Cthulhu.jl
that referenced
this pull request
Oct 7, 2022
aviatesk
added a commit
to aviatesk/Enzyme.jl
that referenced
this pull request
Oct 7, 2022
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Oct 7, 2022
DilumAluthge
removed
the
merge me
vchuravy
added a commit
to EnzymeAD/Enzyme.jl
that referenced
this pull request
Oct 7, 2022
* adjust to JuliaLang/julia#46965 * Update src/compiler/interpreter.jl Co-authored-by: Valentin Churavy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another trial of #46963.
The purpose is to drop #46962 and see if it cuts off the allocation regressions.
The original description follows:
So that
inlining_policycan see user-CallInfoobject. It allows us to implement a customized inlining heuristics by just seeing a callsite information, without requiring the inlining cost of cached code to be tweaked.