-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiler: set up CallInfo
interface type
#46961
Conversation
@nanosoldier |
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me.
6796108
to
fb34f00
Compare
@nanosoldier |
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
4d2f51e
to
c26c2fa
Compare
@nanosoldier |
@nanosoldier |
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
CallInfo
interface typeCallInfo
interface type
8b8175b
to
e15304a
Compare
This commit defines new `CallInfo` abstract type that is supposed to be interfaced by all callinfos like `MethodMatchInfo`. Actual interface features will be added in follow commits.
This has caused significant regressions in PkgEval: https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_date/2022-10/07/report.html The source seems to be IRTools/Zygote, which obviously is used by a significant part of the ecosystem:
|
Should be fixed by FluxML/IRTools.jl#101. |
This commit defines new
CallInfo
abstract type that is supposed to be interfaced by all callinfos likeMethodMatchInfo
. Actual interface features will be added in follow commits.