win: Propagate crashes to OS crash handlers #46224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar in spirit to #46157. We'd like to collect crashdumps when julia crashes on CI, but currently we just cleanly exit the pocess in this case. By continuing exception handling into the global crash handler, the OS's crash reporter gets invoked and can dump out a minidump for us. In the future, we may want to add our own crash reported, but this should hopefully help debug crashes for the moment.
DilumAluthge
force-pushed
the
kf/winecrashreport
branch
from
cd6b8e9 to
fae94c5
Compare
|
I don't think this is actually working properly. It does trigger the debugger under wine, but on Windows proper, I don't see any crashdumps show up (though I did check with a simple C++ file that WER is configured properly). I need to investigate more. I suppose it's also possible that mingw and WER don't get along. |
|
libuv might turn this off on you, as recommended by microsoft documentation: https://github.com/libuv/libuv/blob/c7088010ad137609af473d570fadb6ac2f6f6225/src/win/core.c#L72-L74 |
|
Solved by @staticfloat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar in spirit to #46157. We'd like to collect crashdumps
when julia crashes on CI, but currently we just cleanly exit
the pocess in this case. By continuing exception handling into
the global crash handler, the OS's crash reporter gets invoked
and can dump out a minidump for us. In the future, we may want
to add our own crash reported, but this should hopefully help
debug crashes for the moment.