Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alder lake to processor list #44696

Merged
merged 6 commits into from
May 11, 2022
Merged

Conversation

gbaraldi
Copy link
Member

Initial fix for #44691.
Alder lake also has the AVX-VNNI extension, but I haven't seen what are the correct bit masks for that feature in LLVM so that I can add them to features_x86.h.

@oscardssmith
Copy link
Member

While we're doing this, would it make sense to say that unknown Intel+AMD CPUs have FMA and AVX2? It seems reasonable to assume that any cpu we don't know about is new.

@yuyichao
Copy link
Contributor

The bitmask is not related to LLVM. It's simply the CPU ID value and should be added here

JL_FEATURE_DEF(avx512bf16, 32 * 9 + 5, 0)
with bit 4 instead of bit 5.

The feature is also available in LLVM and it's name is avxvnni https://github.com/llvm/llvm-project/blob/80ec0ebfdc5692a58e0832125f2c6a991df9d63f/llvm/lib/Target/X86/X86.td#L163 and it was added in LLVM 12 as well.

@yuyichao
Copy link
Contributor

While we're doing this, would it make sense to say that unknown Intel+AMD CPUs have FMA and AVX2? It seems reasonable to assume that any cpu we don't know about is new.

This should not be needed. Even without this, avx2 and fma should have been enabled since we do a full feature detection. The only thing missing is scheduling model.

@yuyichao
Copy link
Contributor

yuyichao commented Mar 22, 2022

LGTM other than the required compilation fix.

It's still good to know the exact feature set the processor supports. I doubt your i5 would have more features than the i7 but maybe the OS can mask these? This won't affect runtime since the correct features will be detected (and I don't think the affected features will change codegen in any way...) but may make a difference if you are compiling the system image for the target...

@yuyichao
Copy link
Contributor

@gbaraldi
Copy link
Member Author

gbaraldi commented Apr 5, 2022

Bump :)

@KristofferC
Copy link
Member

Merging based on #44696 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants