-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alder lake to processor list #44696
Conversation
While we're doing this, would it make sense to say that unknown Intel+AMD CPUs have FMA and AVX2? It seems reasonable to assume that any cpu we don't know about is new. |
The bitmask is not related to LLVM. It's simply the CPU ID value and should be added here Line 111 in cf999af
The feature is also available in LLVM and it's name is |
This should not be needed. Even without this, avx2 and fma should have been enabled since we do a full feature detection. The only thing missing is scheduling model. |
LGTM other than the required compilation fix. It's still good to know the exact feature set the processor supports. I doubt your i5 would have more features than the i7 but maybe the OS can mask these? This won't affect runtime since the correct features will be detected (and I don't think the affected features will change codegen in any way...) but may make a difference if you are compiling the system image for the target... |
And just for reference, the cldemote claim comes from here https://github.com/JuliaLang/llvm-project/blob/bc5644ee74f4cb42042257ac129d2be1c252e3f2/llvm/lib/Target/X86/X86.td#L967 |
Bump :) |
Merging based on #44696 (comment). |
Initial fix for #44691.
Alder lake also has the AVX-VNNI extension, but I haven't seen what are the correct bit masks for that feature in LLVM so that I can add them to
features_x86.h
.