Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix (add|set)env to keep currently set dir for the command #43276

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Fix (add|set)env to keep currently set dir for the command #43276

merged 1 commit into from
Dec 1, 2021

Conversation

fredrikekre
Copy link
Member

Fix (add|set)env to keep currently set dir for the command, fixes #42131.

@fredrikekre fredrikekre added bugfix This change fixes an existing bug backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Nov 30, 2021
staticfloat
staticfloat approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@staticfloat staticfloat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fredrikekre fredrikekre merged commit f53de73 into master Dec 1, 2021
@fredrikekre fredrikekre deleted the fe/setenv-keep-dir branch December 1, 2021 02:52
@vtjnash
Copy link
Member

vtjnash commented Dec 1, 2021

Is this actually a valid backport candidate? It seems new-feature-ish-y

@fredrikekre
Copy link
Member Author

If someone relies on setenv to reset the dir? Seems unlikely, no? I don't see any obvious examples when code grepping. Perhaps the fix to addenv could be backported, that was never documented to touch dir at all, but seems a bit half-assed to just fix addenv.

This was referenced Dec 2, 2021
Merged
Merged
@KristofferC KristofferC mentioned this pull request Jan 5, 2022
Merged
23 tasks
KristofferC pushed a commit that referenced this pull request Jan 10, 2022
@fredrikekre @KristofferC
Fix (add|set)env to keep currently set dir for the command, fixes #42131
4280bc4 
. (#43276)

(cherry picked from commit f53de73)
@KristofferC KristofferC mentioned this pull request Jan 10, 2022
Merged
50 tasks
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@fredrikekre @LilithHafner
Fix (add|set)env to keep currently set dir for the command, fixes Jul…
3e40552 
…iaLang#42131. (JuliaLang#43276)
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@fredrikekre @LilithHafner
Fix (add|set)env to keep currently set dir for the command, fixes Jul…
1c0ecc3 
…iaLang#42131. (JuliaLang#43276)
KristofferC pushed a commit that referenced this pull request Mar 15, 2022
@fredrikekre
Fix (add|set)env to keep currently set dir for the command, fixes #42131
1c3286e 
. (#43276)

(cherry picked from commit f53de73)
KristofferC pushed a commit that referenced this pull request Mar 16, 2022
@fredrikekre
Fix (add|set)env to keep currently set dir for the command, fixes #42131
90a3726 
. (#43276)

(cherry picked from commit f53de73)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label May 16, 2022
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@fredrikekre @staticfloat
Fix (add|set)env to keep currently set dir for the command, fixes #42131
d3c51bd 
. (#43276)

(cherry picked from commit f53de73)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticfloat staticfloat staticfloat approved these changes

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why does setenv & thus addenv discard the cmd's dir?
5 participants
@fredrikekre @vtjnash @staticfloat @Keno @KristofferC