Widen RangeIndex from Int to BitInteger #43262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 28, 2022
mkitti
force-pushed
the
patch-4
branch
2 times, most recently
from
658999c to
95df4b4
Compare
|
This PR should have a test. |
Yes, thanks for reminding me. As you can see, I also am still trying to get the current tests to pass. |
|
Are any of the test failures related? |
StefanKarpinski
force-pushed
the
patch-4
branch
from
8547cc7 to
ce5a525
Compare
|
Thanks for the rebase. I'm embarrassed by the poor branch naming here. |
|
@StefanKarpinski, is there anything here for me to fix? |
|
Nope, all good! Thanks for the PR. |
vtjnash
reviewed
Oct 26, 2022
| @@ -112,6 +112,8 @@ struct RefArray{T,A<:AbstractArray{T},R} <: Ref{T} | |||
| end | |||
| RefArray(x::AbstractArray{T}, i::Int, roots::Any) where {T} = RefArray{T,typeof(x),Any}(x, i, roots) | |||
| RefArray(x::AbstractArray{T}, i::Int=1, roots::Nothing=nothing) where {T} = RefArray{T,typeof(x),Nothing}(x, i, nothing) | |||
| RefArray(x::AbstractArray{T}, i::Integer, roots::Any) where {T} = RefArray{T,typeof(x),Any}(x, Int(i), roots) | |||
| RefArray(x::AbstractArray{T}, i::Integer=1, roots::Nothing=nothing) where {T} = RefArray{T,typeof(x),Nothing}(x, Int(i), nothing) | |||
There was a problem hiding this comment.
Suggested change
| RefArray(x::AbstractArray{T}, i::Integer=1, roots::Nothing=nothing) where {T} = RefArray{T,typeof(x),Nothing}(x, Int(i), nothing) | |
| RefArray(x::AbstractArray{T}, i::Integer, roots::Nothing=nothing) where {T} = RefArray{T,typeof(x),Nothing}(x, Int(i), nothing) |
I don't think you meant to overwrite the previous RefArray(x::AbstractArray{T}) method here
There was a problem hiding this comment.
I created a new pull request in #47337
mkitti
added a commit
to mkitti/julia
that referenced
this pull request
Oct 26, 2022
This removes the default argument in `RefArray(x::AbstractArray{T}, i::Integer=1)` such that it does not override `RefArray(x::AbstractArray{T}, i::Int=1)`
xref: JuliaLang#43262 (comment)
cc: @vtjnash
vtjnash
pushed a commit
that referenced
this pull request
Oct 28, 2022
This removes the default argument in `RefArray(x::AbstractArray{T}, i::Integer=1)`
such that it does not override `RefArray(x::AbstractArray{T}, i::Int=1)`.
Refs: #43262 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could we widen
RangeIndexto include indices that are aBitInteger?