-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to Julia 1.7 Docs PDF 404's #43317
Comments
This is the last releases build that passed: https://github.com/JuliaLang/docs.julialang.org/actions/runs/1518462133 (3 days ago) |
One possible issue, a dep version bump. The repo does not have a Project.toml file so it installs the latest versions it needs which could be breaking Edit: Not the issue, the project file is getting cached somewhere Edit Edit: Maybe related to this: 4486567? |
@KristofferC @fredrikekre any ideas here? |
Most likely some new part of the doc doesn't compile in tex. (I believe this happened months ago so I don't think it is useful to just look at recent commits.) |
We should test the existence of the pdf as part of the release process, if possible. I am wondering if we can detect that the pdf generation failed and not include the pdf link in the documentation. |
I tried the |
Might #43342 be a possible culprit? |
How long does the PDF take to build? Should we add a Buildkite job (https://github.com/JuliaCI/julia-buildkite) for it? Normally, I would never recommend that we add a Buildkite job if the same thing can be accomplished with GitHub Actions. However, in this specific case, the job (PDF docs for Base Julia) is very much within the scope of Base Julia CI, so I would not object to adding this to Buildkite. |
A few minutes, I think. It's definitely within the scope of Base Julia, and needs tons of tex packages installed on the system. I suppose it could be made part of the doctests and then we can fail the doctests if the pdf build fails. |
We would just build a rootfs image (https://github.com/JuliaCI/rootfs-images) with the necessary dependencies.
A few minutes is quick enough that we can just add this to the doctests and run it on every PR. |
Is it actually just a few minutes, though? Looks like the last successful run took more than 30 minutes: https://github.com/JuliaLang/docs.julialang.org/actions/runs/576633576 |
Also, note that the last time the nightly PDF built successfully was 10 months ago, so that's probably where you would want to look to find the breakage. |
link to doc: https://docs.julialang.org/ |
I see the PDF is available but it is for 1.7.2. It shouldn't matter but would be nice to have the correct one. |
Per a discussion in Discorse, the link to the PDF of the docs 404s: https://docs.julialang.org/en/v1/
It looks like this is due to a CI failure: https://github.com/JuliaLang/docs.julialang.org/runs/4402414711?check_suite_focus=true
The text was updated successfully, but these errors were encountered: