-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the REPL command ] generate
#1923
Conversation
This looks good to me. @KristofferC, you good with this now? If so, let's squash-merge it. |
😢 bring it back please |
Why? |
edit: totally missed that it is just I use both IMO it feels strange to have a split between the API and functions available to user in Pkg |
We kept getting complaints that |
I'm also a frequent user of
I think the current implementation is already good. I see that there are a couple related open issues (#759, #1917, #2168), I would be willing to help with those if needed. |
Yeah keep it how it is and just stress it is only for minimal package generation. if anybody asks for more then give them PkgTemplates |
That would be fine if someone wants to revert this and fix those related issues. |
I took a stab at this. Let me know if you think #2492 would do the trick. |
This PR deprecates the REPL command
] generate
but leavesPkg.generate
untouched.@StefanKarpinski @KristofferC