Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the REPL command ] generate #1923

Merged
merged 4 commits into from
Jul 18, 2020
Merged

Deprecate the REPL command ] generate #1923

merged 4 commits into from
Jul 18, 2020

Conversation

DilumAluthge
Copy link
Member

This PR deprecates the REPL command ] generate but leaves Pkg.generate untouched.

@StefanKarpinski @KristofferC

@StefanKarpinski
Copy link
Member

This looks good to me. @KristofferC, you good with this now? If so, let's squash-merge it.

@DilumAluthge
Copy link
Member Author

Bump @StefanKarpinski @KristofferC

@StefanKarpinski StefanKarpinski merged commit 13456b9 into JuliaLang:master Jul 18, 2020
@DilumAluthge DilumAluthge deleted the patch-2 branch July 19, 2020 01:59
@anandijain
Copy link

😢 bring it back please

@StefanKarpinski
Copy link
Member

Why?

@anandijain
Copy link

anandijain commented Apr 6, 2021

edit: totally missed that it is just ] generate. Still think REPL version should exist.

I use both Pkg.generate() and ]generate frequently.

IMO it feels strange to have a split between the API and functions available to user in Pkg

@StefanKarpinski
Copy link
Member

We kept getting complaints that generate was broken or insufficient and no one here wanted to maintain it or make it do all the things that people wanted it to do for them. Would you be willing to figure out what a built-in bare bones generate needs to support and make sure it implements those things?

@pazner
Copy link
Contributor

pazner commented Apr 6, 2021

I'm also a frequent user of ] generate and was disappointed to see that it was deprecated.

We kept getting complaints that generate was broken or insufficient and no one here wanted to maintain it or make it do all the things that people wanted it to do for them. Would you be willing to figure out what a built-in bare bones generate needs to support and make sure it implements those things?

I think the current implementation is already good. I see that there are a couple related open issues (#759, #1917, #2168), I would be willing to help with those if needed.

@anandijain
Copy link

Yeah keep it how it is and just stress it is only for minimal package generation. if anybody asks for more then give them PkgTemplates

@StefanKarpinski
Copy link
Member

That would be fine if someone wants to revert this and fix those related issues.

@pazner pazner mentioned this pull request Apr 6, 2021
@pazner
Copy link
Contributor

pazner commented Apr 7, 2021

That would be fine if someone wants to revert this and fix those related issues.

I took a stab at this. Let me know if you think #2492 would do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants