Skip to content

Use core::error::Error in codebase #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 6, 2025
Merged

Use core::error::Error in codebase #466

merged 9 commits into from
May 6, 2025

Conversation

tyranron
Copy link
Collaborator

@tyranron tyranron commented May 6, 2025

Synopsis

We had TODOs across the code:

// TODO: Use `derive_more::core::error::Error` once `error_in_core` Rust feature is
//       stabilized.

The feature(error_in_core) was stabilized in 1.81 Rust.
It's long enough, so we can bump up our MSRV.

Solution

  • Use core::error::Error in codebase and remove feature = "std" gating for it.
  • Bump up MSRV to 1.81.

Checklist

  • Documentation is updated
  • Tests are added/updated
  • CHANGELOG entry is added

@tyranron tyranron added this to the 2.1.0 milestone May 6, 2025
@tyranron tyranron self-assigned this May 6, 2025
@tyranron tyranron marked this pull request as ready for review May 6, 2025 14:59
@tyranron
Copy link
Collaborator Author

tyranron commented May 6, 2025

@JelteF please, update also required CI tasks to MSRV 1.81.0. Thanks!

@tyranron tyranron requested a review from JelteF May 6, 2025 15:01
@tyranron tyranron enabled auto-merge (squash) May 6, 2025 15:02
@tyranron tyranron requested a review from JelteF May 6, 2025 15:14
JelteF
JelteF previously approved these changes May 6, 2025
@tyranron
Copy link
Collaborator Author

tyranron commented May 6, 2025

@JelteF to merge this we require to change required CI jobs to 1.81.0 MSRV in master branch protection rules.

@JelteF
Copy link
Owner

JelteF commented May 6, 2025

@JelteF to merge this we require to change required CI jobs to 1.81.0 MSRV in master branch protection rules.

I think it would be good to remove the version number from the MSRV build name. So we don't have this problem everytime we bump it.

@tyranron
Copy link
Collaborator Author

tyranron commented May 6, 2025

@JelteF done!

@tyranron tyranron requested a review from JelteF May 6, 2025 16:03
@JelteF JelteF disabled auto-merge May 6, 2025 16:05
@JelteF JelteF merged commit 211165a into master May 6, 2025
17 checks passed
@JelteF JelteF deleted the error-in-core branch May 6, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants