Skip to content

[MOB-12043] Remove Android Module Dead Code #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2023
Merged

[MOB-12043] Remove Android Module Dead Code #884

merged 1 commit into from
Mar 5, 2023

Conversation

TheBuggedYRN
Copy link
Contributor

Description of the change

Description goes here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@InstabugCI
Copy link
Collaborator

1 Warning
⚠️ You have not included a CHANGELOG entry!
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

@a7medev a7medev mentioned this pull request Feb 23, 2023
Merged
7 tasks
@TheBuggedYRN TheBuggedYRN reopened this Feb 26, 2023
@TheBuggedYRN TheBuggedYRN force-pushed the refactor/clean-instabug-android-module branch 3 times, most recently from c53b3c2 to 2701f05 Compare February 28, 2023 14:44
@TheBuggedYRN TheBuggedYRN self-assigned this Mar 1, 2023
@TheBuggedYRN TheBuggedYRN marked this pull request as ready for review March 1, 2023 09:58
Base automatically changed from dev to master March 1, 2023 15:24
@TheBuggedYRN TheBuggedYRN changed the base branch from master to dev March 2, 2023 12:02
@TheBuggedYRN TheBuggedYRN force-pushed the refactor/clean-instabug-android-module branch from 2701f05 to 09eec7e Compare March 2, 2023 12:05
a7medev
a7medev approved these changes Mar 5, 2023
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👏 This is a pretty good step towards a cleaner code base.

@TheBuggedYRN TheBuggedYRN changed the title Remove Android Module Dead Code [MOB-12043] Remove Android Module Dead Code Mar 5, 2023
@TheBuggedYRN TheBuggedYRN merged commit 102ddc3 into dev Mar 5, 2023
@TheBuggedYRN TheBuggedYRN deleted the refactor/clean-instabug-android-module branch March 5, 2023 14:13
HeshamMegid pushed a commit that referenced this pull request Apr 20, 2023
@TheBuggedYRN @HeshamMegid
[MOB-12043] Remove Android Module Dead Code (#884)
4286778
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev a7medev approved these changes

@DavidMina96 DavidMina96 Awaiting requested review from DavidMina96

Assignees

@TheBuggedYRN TheBuggedYRN

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheBuggedYRN @InstabugCI @a7medev