Skip to content

feat(example): customize chat settings #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 28, 2024
Merged

feat(example): customize chat settings #1156

merged 4 commits into from
Feb 28, 2024

Conversation

ahmedAlaaInstabug
Copy link
Contributor

@ahmedAlaaInstabug ahmedAlaaInstabug commented Feb 27, 2024 •
edited by jira bot
Loading

Description of the change

  1. add a switch to enable chat
  2. add a switch to enable in-app replay sound
  3. add a switch to enable system replay sound
  4. add a switch to enable push notification
Replies Screen
Screenshot_1708982783

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID = MOB-13954

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@ahmedAlaaInstabug ahmedAlaaInstabug self-assigned this Feb 27, 2024
@ahmedAlaaInstabug ahmedAlaaInstabug changed the title fix(example): customize chat settings feat(example): customize chat settings Feb 27, 2024
@mnoseir
Copy link

mnoseir commented Feb 27, 2024 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 96.3% ✅
Android 47.8% ✅
iOS 41.7% ✅

Generated by 🚫 dangerJS against b64692a

abdelhamid-f-nasser
abdelhamid-f-nasser suggested changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmedAlaaInstabug Great effort extending the Chat settings in the sample app 💪 🔥, I love how your work is evolving the app 👍.

Please check the code suggestions 🙏 .

@ahmedAlaaInstabug ahmedAlaaInstabug merged commit ff3c0ab into dev Feb 28, 2024
@ahmedAlaaInstabug ahmedAlaaInstabug deleted the feat/exampe_customize-chat-settings branch February 28, 2024 12:42
abdelhamid-f-nasser pushed a commit that referenced this pull request Feb 28, 2024
@ahmedAlaaInstabug @abdelhamid-f-nasser
feat(example): customize chat settings (#1156)
0d0db4c 
* feat(example): customize chat settings

* feat(example): customize chat settings

* fix: pr comments
abdelhamid-f-nasser pushed a commit that referenced this pull request Feb 28, 2024
@ahmedAlaaInstabug @abdelhamid-f-nasser
feat(example): customize chat settings (#1156)
bc7d913 
* feat(example): customize chat settings

* feat(example): customize chat settings

* fix: pr comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdelhamid-f-nasser abdelhamid-f-nasser abdelhamid-f-nasser approved these changes

@a7medev a7medev Awaiting requested review from a7medev

Assignees

@ahmedAlaaInstabug ahmedAlaaInstabug

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedAlaaInstabug @mnoseir @abdelhamid-f-nasser