Skip to content

fix(android): resolve JsonException handling error #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2024
Merged

fix(android): resolve JsonException handling error #1089

merged 1 commit into from
Jan 8, 2024

Conversation

abdelhamid-f-nasser
Copy link
Contributor

Description of the change

Update exception handling in parseConsoleLogs method to resolve the error related to JSON serialization exceptions. Modify the try-catch block to handle potential JSON exceptions effectively using a wider exceptions type.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: MOB-13598

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@abdelhamid-f-nasser abdelhamid-f-nasser changed the title fix(android): reports JsonException handling error fix(android): resolve JsonException handling error Jan 8, 2024
@abdelhamid-f-nasser abdelhamid-f-nasser changed the base branch from master to dev January 8, 2024 20:28
@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the fix/json-exception-handling-error branch from ac86a5f to d678bf9 Compare January 8, 2024 20:36
@InstabugCI
Copy link
Collaborator

Coverage Report

Label Coverage Status
JavaScript 96.2% ✅
Android 50.2% ✅
iOS 40.6% ✅

Generated by 🚫 dangerJS against d678bf9

@abdelhamid-f-nasser abdelhamid-f-nasser merged commit bb9f297 into dev Jan 8, 2024
@abdelhamid-f-nasser abdelhamid-f-nasser deleted the fix/json-exception-handling-error branch January 8, 2024 23:35
abdelhamid-f-nasser added a commit that referenced this pull request Jan 8, 2024
@abdelhamid-f-nasser
fix(android): resolve JsonException handling error (#1089)
e545cf1 
Jira ID: MOB-13598
HeshamMegid pushed a commit that referenced this pull request Jan 9, 2024
@abdelhamid-f-nasser @HeshamMegid
fix(android): resolve JsonException handling error (#1089)
e3bb95f 
Jira ID: MOB-13598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdelhamid-f-nasser @InstabugCI