Skip to content

feat(example): add user steps demos #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Dec 13, 2023
Merged

feat(example): add user steps demos #1047

merged 16 commits into from
Dec 13, 2023

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Nov 1, 2023

Description of the change

Added user steps demos to the example app with the following:

  • Basic components:
    • Text
    • Image
    • Text Input
    • Button
    • Pressable
    • Touchable
    • Switch
    • Slider
    • Activity Indicator
  • Scrollables:
    • Scroll View
    • Flat List
    • Section List
  • Gestures
    • Tap
    • Double Tap
    • Swipe
    • Pinch

These features were added to the example app to ease the testing of user steps support in React Native.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: IBGCRASH-20289

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@InstabugCI
Copy link
Collaborator

InstabugCI commented Nov 16, 2023

Coverage Report

Label Coverage Status
JavaScript 96.2%
Android 50.2%
iOS 40.6%

Generated by 🚫 dangerJS against db480d0

Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort and magnificent job @a7medev! this will help us a lot while testing.

Only note is we can separate the newly added screens to a separate package/directory.

@a7medev a7medev self-assigned this Dec 13, 2023
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @a7medev, let's merge this ASAP.
LGTM

@a7medev a7medev changed the base branch from master to dev December 13, 2023 16:57
@a7medev a7medev merged commit 498bfe6 into dev Dec 13, 2023
@a7medev a7medev deleted the chore/add-user-steps-demo branch December 13, 2023 16:58
HeshamMegid pushed a commit that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants