fix: use a fallback for empty screen names #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7medev
requested review from
kholood-ea,
AndrewAminInstabug and
AyaMahmoud148
AndrewAminInstabug
approved these changes
Sep 5, 2024
ahmedAlaaInstabug
pushed a commit
that referenced
this pull request
Nov 4, 2024
* fix: fallback to N/A when for empty screen names * test: add test for empty screen fallback * chore: add changelog item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fallback to "N/A" when a screen with an empty screen name is observed, this prevents crashes in
ScreenLoadingManagerbecause the screen name is empty and prevents the screen change event from being dropped.Type of change
Related issues
Jira ID: INSD-12170
Fixes #504
Checklists
Development
Code review