Skip to content

fix(android): add w3c external trace attributes placeholder #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 5, 2024
Merged

fix(android): add w3c external trace attributes placeholder #491

merged 4 commits into from
Aug 5, 2024

Conversation

kholood-ea
Copy link
Contributor

Description of the change

Add W3C External Trace Attributes Placeholder For Android

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

JiraID:MOB-14980

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@kholood-ea kholood-ea self-assigned this Jul 31, 2024
@InstabugCI
Copy link
Collaborator

InstabugCI commented Jul 31, 2024 •
edited
Loading

Coverage Report

Label Coverage Status
Dart 82.3% ✅

Generated by 🚫 dangerJS against 28d6c14

@kholood-ea kholood-ea force-pushed the fix/android-network-logs branch from 5322bad to dc26744 Compare July 31, 2024 14:05
a7medev
a7medev approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏼

@a7medev a7medev self-requested a review August 2, 2024 07:51
a7medev
a7medev requested changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is fine but we need to update the native Android tests as well since they're currently failing due to the changed method signature, can you please fix that? 🙏🏼

@a7medev a7medev force-pushed the fix/android-network-logs branch from b3cd866 to 28d6c14 Compare August 5, 2024 08:30
@a7medev a7medev self-requested a review August 5, 2024 09:05
@a7medev a7medev merged commit 409575f into dev Aug 5, 2024
10 of 11 checks passed
@a7medev a7medev deleted the fix/android-network-logs branch August 5, 2024 09:05
ahmedAlaaInstabug pushed a commit that referenced this pull request Nov 4, 2024
@kholood-ea @a7medev @ahmedAlaaInstabug
fix(android): add w3c external trace attributes placeholder (#491)
a562b4a 
* fix(android): add w3c external trace attributes placeholder

* chore: add changelog

* chore: fix formatting

* test: update apm network log signature in mocks

---------

Co-authored-by: Ahmed Mahmoud <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev a7medev approved these changes

@ahmedAlaaInstabug ahmedAlaaInstabug Awaiting requested review from ahmedAlaaInstabug

@AndrewAminInstabug AndrewAminInstabug Awaiting requested review from AndrewAminInstabug

Assignees

@kholood-ea kholood-ea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kholood-ea @InstabugCI @a7medev