feat: attach w3c header #481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedAlaaInstabug
requested review from
a7medev,
AndrewAminInstabug and
kholood-ea
android/src/main/java/com/instabug/flutter/modules/InstabugApi.java
Outdated
Show resolved
Hide resolved
|
|
||
|
|
||
| internalAPM.verify(() -> InternalAPM._registerCPFeaturesChangeListener(any(FeaturesChangeListener.class))); | ||
| internalAPM.close(); |
There was a problem hiding this comment.
Can we improve the code indentation for better readability?
AndrewAminInstabug
previously approved these changes
Aug 1, 2024
a7medev
requested changes
Aug 20, 2024
ahmedAlaaInstabug
dismissed
AndrewAminInstabug’s stale review
The base branch was changed.
a7medev
requested changes
Sep 25, 2024
There was a problem hiding this comment.
Good job @ahmedAlaaInstabug! 👏🏼👏🏼
I've added some suggestions so please check them out and let me know your thoughts 🙏🏼
Also, can we please address the issue with the code coverage drop? 🙏🏼
android/src/main/java/com/instabug/flutter/modules/InstabugApi.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/instabug/flutter/modules/InstabugApi.java
Outdated
Show resolved
Hide resolved
android/src/test/java/com/instabug/flutter/InstabugApiTest.java
Outdated
Show resolved
Hide resolved
a7medev
previously approved these changes
Nov 4, 2024
a7medev
previously approved these changes
Nov 4, 2024
ahmedAlaaInstabug
force-pushed
the
feat/attach-w3c-header
branch
from
4b790a1 to
b5d86ba
Compare
ahmedAlaaInstabug
dismissed
a7medev’s stale review
The merge-base changed after approval.
ahmedAlaaInstabug
force-pushed
the
feat/attach-w3c-header
branch
from
b5d86ba to
4b790a1
Compare
ahmedAlaaInstabug
force-pushed
the
feat/attach-w3c-header
branch
from
4b790a1 to
2efcb3f
Compare
# Conflicts: # CHANGELOG.md # android/build.gradle # android/src/main/java/com/instabug/flutter/modules/ApmApi.java # android/src/main/java/com/instabug/flutter/modules/InstabugApi.java # android/src/test/java/com/instabug/flutter/ApmApiTest.java # android/src/test/java/com/instabug/flutter/InstabugApiTest.java # example/lib/src/components/network_content.dart # example/pubspec.lock # ios/Classes/Modules/InstabugApi.m # ios/Classes/Util/IBGNetworkLogger+CP.h # lib/src/modules/instabug.dart
a7medev
previously approved these changes
Nov 7, 2024
a7medev
approved these changes
Nov 10, 2024
mzelzoghbi
pushed a commit
that referenced
this pull request
Nov 18, 2024
* fix: add support for newer gradle versions (#512) * feat: attach w3c header (#481) * feat: add android feature flag * fix: test cases * fix: test cases * fix: test cases * fix: test cases * fix: add more test cases * fix: add more test cases * fix: add more test cases * fix: add more test cases * Release: v14.0.0 (#532) * chore(android): bump sdk to v14.0.0 * chore(ios): bump sdk to v14.0.0 * Release: v14.0.0 * Release: v14.0.0 * Release: v14.0.0 * chore: change release date (#535) --------- Co-authored-by: kholood <[email protected]>
mzelzoghbi
pushed a commit
that referenced
this pull request
Jan 2, 2025
* fix: add support for newer gradle versions (#512) * feat: attach w3c header (#481) * feat: add android feature flag * fix: test cases * fix: test cases * fix: test cases * fix: test cases * fix: add more test cases * fix: add more test cases * fix: add more test cases * fix: add more test cases * Release: v14.0.0 (#532) * chore(android): bump sdk to v14.0.0 * chore(ios): bump sdk to v14.0.0 * Release: v14.0.0 * Release: v14.0.0 * Release: v14.0.0 * chore: change release date (#535) * Release: 14.1.0 (#539) * release: 14.1.0 * release: 14.1.0 * release: v14.1.0 * release: v14.1.0 --------- Co-authored-by: kholood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Related issues
JIRA ID: MOB-14497
Checklists
Development
Code review