feat: enhance non-fatals support #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # example/ios/Podfile.lock # example/pubspec.lock # ios/instabug_flutter.podspec
# Conflicts: # example/ios/Podfile.lock # example/lib/main.dart # example/pubspec.lock
android/src/main/java/com/instabug/flutter/modules/CrashReportingApi.java
Outdated
Show resolved
Hide resolved
a7medev
requested changes
Apr 29, 2024
There was a problem hiding this comment.
Good job @ahmedAlaaInstabug! 👏🏼 I have added some comments so please check them and let me know your thoughts. 🙏🏼
Side note: some iOS code/tests are broken because the snapshot is on v12.7.1 which doesn't contain App Flows and this branch's base has App Flows in it.
android/src/main/java/com/instabug/flutter/modules/CrashReportingApi.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/instabug/flutter/modules/CrashReportingApi.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/instabug/flutter/modules/CrashReportingApi.java
Outdated
Show resolved
Hide resolved
android/src/test/java/com/instabug/flutter/CrashReportingApiTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Ahmed Mahmoud <[email protected]>
…t/add-non-fatal-api
AndrewAminInstabug
previously approved these changes
Apr 29, 2024
mzelzoghbi
dismissed
AndrewAminInstabug’s stale review
The base branch was changed.
# Conflicts: # CHANGELOG.md # example/ios/Podfile.lock # ios/instabug_flutter.podspec
# Conflicts: # e2e/BugReportingTests.cs # example/android/app/src/main/AndroidManifest.xml # example/android/app/src/main/res/xml/network_security_config.xml # example/lib/main.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Related issues
JIRA ID: MOB-13793
Development
Code review