Skip to content

feat: support identify user by id #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 14, 2024
Merged

feat: support identify user by id #435

merged 3 commits into from
Feb 14, 2024

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Jan 30, 2024

Description of the change

Support user identification by ID in Instabug.identifyUser.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: MOB-13745

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev self-assigned this Jan 30, 2024
@mnoseir
Copy link

mnoseir commented Jan 30, 2024 •
edited
Loading

Coverage Report

Label Coverage Status
Dart 85.8% ✅

Generated by 🚫 dangerJS against c94dad0

abdelhamid-f-nasser
abdelhamid-f-nasser approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a7medev Let's generate a snapshot and send it over !!
LGTM-mr-beans

@a7medev a7medev merged commit bfa0e04 into dev Feb 14, 2024
@a7medev a7medev deleted the feat/identify-user-with-id branch February 14, 2024 12:17
HeshamMegid pushed a commit that referenced this pull request Feb 15, 2024
@a7medev @HeshamMegid
feat: support identify user by id (#435)
08ef119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdelhamid-f-nasser abdelhamid-f-nasser abdelhamid-f-nasser approved these changes

@ahmedAlaaInstabug ahmedAlaaInstabug Awaiting requested review from ahmedAlaaInstabug

Assignees

@a7medev a7medev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a7medev @mnoseir @abdelhamid-f-nasser