Skip to content

feat: add session replay mode argument to reprosteps api #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 27, 2023
Merged

feat: add session replay mode argument to reprosteps api #398

merged 6 commits into from
Sep 27, 2023

Conversation

abdelhamid-f-nasser
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser commented Sep 25, 2023 •
edited by jira bot
Loading

Description of the change

  • Add session replay mode argument to reprosteps api
  • Refactor tests to match the updates

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

IBGCRASH-20025

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

Depends on

@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the feat/add-new-session-replay-for-repro-steps-api branch from 96920c6 to 5ac7d1a Compare September 25, 2023 18:04
@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the feat/add-new-session-replay-for-repro-steps-api branch 2 times, most recently from 40cf308 to 059d8ab Compare September 26, 2023 07:30
@InstabugCI
Copy link
Collaborator

InstabugCI commented Sep 26, 2023 •
edited
Loading

Warnings
⚠️

You have not included a CHANGELOG entry!
You can find it at CHANGELOG.md.

Coverage Report

Label Coverage Status
Dart 85.4% ✅

Generated by 🚫 dangerJS against 0b72cfc

@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the chore/bump-android-sdk-12.1.0 branch from 7d40638 to dced9f6 Compare September 26, 2023 13:49
@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the feat/add-new-session-replay-for-repro-steps-api branch from 059d8ab to 3e3e848 Compare September 26, 2023 13:52
@a7medev a7medev force-pushed the chore/bump-android-sdk-12.1.0 branch from dced9f6 to c5a3146 Compare September 26, 2023 14:58
Base automatically changed from chore/bump-android-sdk-12.1.0 to dev September 26, 2023 15:02
@a7medev a7medev force-pushed the feat/add-new-session-replay-for-repro-steps-api branch from 3e3e848 to 1047530 Compare September 27, 2023 07:43
@a7medev a7medev merged commit a575b00 into dev Sep 27, 2023
@a7medev a7medev deleted the feat/add-new-session-replay-for-repro-steps-api branch September 27, 2023 16:31
HeshamMegid pushed a commit that referenced this pull request Sep 28, 2023
@abdelhamid-f-nasser @a7medev @HeshamMegid
feat: add session replay mode argument to reprosteps api (#398)
4030ab5 
Jira ID: IBGCRASH-20025

Co-authored-by: Ahmed Mahmoud <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev a7medev approved these changes

@asamiz asamiz Awaiting requested review from asamiz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abdelhamid-f-nasser @InstabugCI @a7medev