Skip to content

chore: remove deprecated apis #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 26, 2023
Merged

chore: remove deprecated apis #385

merged 11 commits into from
Sep 26, 2023

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Sep 7, 2023 •
edited
Loading

Description of the change

Removed all deprecated APIs for v12.0.0

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev self-assigned this Sep 7, 2023
@InstabugCI
Copy link
Collaborator

InstabugCI commented Sep 7, 2023 •
edited
Loading

Coverage Report

Label Coverage Status
Dart 85.4% ✅

Generated by 🚫 dangerJS against e7666ea

@a7medev a7medev force-pushed the chore/remove-deprecated-apis branch from 0a6d313 to db35192 Compare September 10, 2023 11:57
Base automatically changed from dev to master September 14, 2023 13:20
@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the chore/remove-deprecated-apis branch from 3a0261d to edba5bb Compare September 21, 2023 09:57
@abdelhamid-f-nasser abdelhamid-f-nasser changed the title [MOB-12997] Remove Deprecated APIs chore: remove deprecated apis Sep 25, 2023
@abdelhamid-f-nasser
Copy link
Contributor

We should add changelog after merging all the child PRs

@a7medev a7medev mentioned this pull request Sep 26, 2023
Merged
7 tasks
@a7medev a7medev changed the base branch from master to dev September 26, 2023 08:59
@a7medev a7medev marked this pull request as ready for review September 26, 2023 13:19
abdelhamid-f-nasser
abdelhamid-f-nasser suggested changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done with the deprecations 💪 🚀 , I'm not sure if this is a change request or not, please check it and let me know your feedback.

@a7medev a7medev merged commit dfc6809 into dev Sep 26, 2023
@a7medev a7medev deleted the chore/remove-deprecated-apis branch September 26, 2023 14:39
HeshamMegid pushed a commit that referenced this pull request Sep 28, 2023
@a7medev @HeshamMegid
chore: remove deprecated apis (#385)
43b8db5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdelhamid-f-nasser abdelhamid-f-nasser abdelhamid-f-nasser approved these changes

@asamiz asamiz Awaiting requested review from asamiz

Assignees

@a7medev a7medev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a7medev @InstabugCI @abdelhamid-f-nasser