Skip to content

feat: support network logs omission #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 11, 2023
Merged

feat: support network logs omission #382

merged 10 commits into from
Sep 11, 2023

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Sep 5, 2023

Description of the change

Adds a new API NetworkLogger.omitLog to allow omitting certain network requests.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: MOB-12524

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev self-assigned this Sep 5, 2023
@InstabugCI
Copy link
Collaborator

InstabugCI commented Sep 5, 2023

Coverage Report

Label Coverage Status
Dart 84.4%

Generated by 🚫 dangerJS against 4fa98d8

@a7medev a7medev changed the title feat: support omitting network logs feat: support network logs omission Sep 5, 2023
@a7medev a7medev marked this pull request as ready for review September 5, 2023 13:40
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort introducing this new API 🚀 . Please check the suggested doc improvement 🙏 .

Copy link
Contributor

@asamiz asamiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @a7medev, this is approval from my side.

@a7medev a7medev force-pushed the feat/network-obfuscation branch from d0d6ef0 to 96b7e1c Compare September 11, 2023 12:20
Base automatically changed from feat/network-obfuscation to dev September 11, 2023 13:09
@a7medev a7medev force-pushed the feat/network-omission branch from 21b7e35 to 0ffbed0 Compare September 11, 2023 13:15
@a7medev a7medev force-pushed the feat/network-omission branch from 66d6be5 to 4fa98d8 Compare September 11, 2023 13:19
@a7medev a7medev merged commit d392432 into dev Sep 11, 2023
@a7medev a7medev deleted the feat/network-omission branch September 11, 2023 13:30
ymabdallah pushed a commit that referenced this pull request Sep 14, 2023
* [MOB-12516] Fix zone mismatch issue (#376)

* fix(initialization): fix zone mismatch issue in initialization code

* fix(initilization): fix the PR comments

* [MOB-12700] Remove danger ruby package (#379)

Remove danger ruby package to resolve dependabot git security vulnerability issue.

* [MOB-12513] Fix Mockito and Pigeon Dependency Conflict (#377)

* Unrestrict a specific Pigeon version

* Unrestrict a specific Mockito version

* Upgrade Flutter CI version with Mockito and Pigeon

* Remove ask question button in example

---------

Co-authored-by: Ahmed Mahmoud <[email protected]>

* test: update captain config (#386)

Jira ID: MOB-13002

* chore(ios): bump sdk to 11.14.0 (#383)

Jira ID: MOB-12993

* feat: support network logs obfuscation (#380)

Jira ID: MOB-12523

* feat: support network logs omission (#382)

Jira ID: MOB-12524

* chore(android): bump sdk to 11.14.0 (#384)

Jira ID: MOB-12992

* feat: add new repro steps api (#388)

Jira ID: MOB-13005

* chore: update sdk version to v11.14.0 (#389)

Jira ID: MOB-13014

---------

Co-authored-by: Ahmed Sami <[email protected]>
Co-authored-by: Ahmed Mahmoud <[email protected]>
Co-authored-by: Ahmed Mahmoud <[email protected]>
HeshamMegid pushed a commit that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants