-
Notifications
You must be signed in to change notification settings - Fork 47
feat: support network logs omission #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdelhamid-f-nasser
suggested changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great effort introducing this new API 🚀 . Please check the suggested doc improvement 🙏 .
61244bb
to
20ca536
Compare
0c367b8
to
21b7e35
Compare
abdelhamid-f-nasser
approved these changes
Sep 10, 2023
asamiz
approved these changes
Sep 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @a7medev, this is approval from my side.
d0d6ef0
to
96b7e1c
Compare
Add docs to obfuscateLog in network_manager.dart
Add docs to omitLog in network_manager.dart
21b7e35
to
0ffbed0
Compare
66d6be5
to
4fa98d8
Compare
ymabdallah
pushed a commit
that referenced
this pull request
Sep 14, 2023
* [MOB-12516] Fix zone mismatch issue (#376) * fix(initialization): fix zone mismatch issue in initialization code * fix(initilization): fix the PR comments * [MOB-12700] Remove danger ruby package (#379) Remove danger ruby package to resolve dependabot git security vulnerability issue. * [MOB-12513] Fix Mockito and Pigeon Dependency Conflict (#377) * Unrestrict a specific Pigeon version * Unrestrict a specific Mockito version * Upgrade Flutter CI version with Mockito and Pigeon * Remove ask question button in example --------- Co-authored-by: Ahmed Mahmoud <[email protected]> * test: update captain config (#386) Jira ID: MOB-13002 * chore(ios): bump sdk to 11.14.0 (#383) Jira ID: MOB-12993 * feat: support network logs obfuscation (#380) Jira ID: MOB-12523 * feat: support network logs omission (#382) Jira ID: MOB-12524 * chore(android): bump sdk to 11.14.0 (#384) Jira ID: MOB-12992 * feat: add new repro steps api (#388) Jira ID: MOB-13005 * chore: update sdk version to v11.14.0 (#389) Jira ID: MOB-13014 --------- Co-authored-by: Ahmed Sami <[email protected]> Co-authored-by: Ahmed Mahmoud <[email protected]> Co-authored-by: Ahmed Mahmoud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds a new API
NetworkLogger.omitLog
to allow omitting certain network requests.Type of change
Related issues
Jira ID: MOB-12524
Checklists
Development
Code review