Skip to content

[MOB-12513] Fix Mockito and Pigeon Dependency Conflict #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Aug 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
2e09753
fix(dependencyConflict): fix Mockito and Pigeon conflict with flutter…
asamiz Jul 27, 2023
918714e
fix(dependencyConflict): add fixed versions for both mockito and pige…
asamiz Jul 27, 2023
76e0a4d
fix(dependencyConflict): revert mockito and pigeon versions with over…
asamiz Jul 27, 2023
e3b112b
fix(dependencyConflict): update all the dependencies and also flutter…
asamiz Jul 27, 2023
7939bd9
fix(dependencyConflict): override matcher version
asamiz Jul 27, 2023
d2f0016
fix(dependencyConflict): revert build_runner version
asamiz Jul 27, 2023
c6ef4ec
fix(dependencyConflict): revert build_runner version
asamiz Jul 27, 2023
7431970
fix(dependencyConflict): remove the overrinding
asamiz Jul 27, 2023
c38f317
fix(dependencyConflict): remove test_api only from the overrinding
asamiz Jul 27, 2023
4fcd9bb
fix(dependencyConflict): add test_api only from the overrinding
asamiz Jul 27, 2023
8d51064
Revert SDK enviornment change
a7medev Aug 2, 2023
8479494
Change Pigeon and Mockito dependency versions
a7medev Aug 2, 2023
f14f7e3
Fix new Pigeon iOS error type
a7medev Aug 2, 2023
b04014e
Install pigeon globally
a7medev Aug 3, 2023
64a921c
Downgrade mockito
a7medev Aug 3, 2023
0ec4c29
Revert "Install pigeon globally"
a7medev Aug 6, 2023
41644f6
Unrestrict a specific Pigeon version
a7medev Aug 6, 2023
6195f54
Unrestrict a specific Mockito version
a7medev Aug 6, 2023
0ebc6b8
Upgrade Flutter CI version with Mockito and Pigeon
a7medev Aug 6, 2023
3e5f942
Remove ask question button in example
a7medev Aug 7, 2023
3c2a71a
Add a note on relaxed pigeon and mockito versions
a7medev Aug 7, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ commands:
setup_flutter:
steps:
- flutter/install_sdk_and_pub:
flutter_version: 3.3.0
flutter_version: 3.10.5
- run:
name: Generate Pigeons
command: sh ./scripts/pigeon.sh
Expand Down
9 changes: 0 additions & 9 deletions example/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -162,11 +162,6 @@ class _MyHomePageState extends State<MyHomePage> {
ReportType.feedback, [InvocationOption.emailFieldOptional]);
}

void askQuestion() {
BugReporting.show(
ReportType.question, [InvocationOption.emailFieldOptional]);
}

void showNpsSurvey() {
Surveys.showSurvey('pcV_mE2ttqHxT1iqvBxL0w');
}
Expand Down Expand Up @@ -333,10 +328,6 @@ class _MyHomePageState extends State<MyHomePage> {
onPressed: sendFeedback,
text: 'Send Feedback',
),
InstabugButton(
onPressed: askQuestion,
text: 'Ask a Question',
),
InstabugButton(
onPressed: showNpsSurvey,
text: 'Show NPS Survey',
Expand Down
4 changes: 2 additions & 2 deletions ios/Classes/Modules/BugReportingApi.m
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ - (void)setEnabledAttachmentTypesScreenshot:(NSNumber *)screenshot extraScreensh

- (void)bindOnInvokeCallbackWithError:(FlutterError *_Nullable *_Nonnull)error {
IBGBugReporting.willInvokeHandler = ^{
[self->_flutterApi onSdkInvokeWithCompletion:^(NSError *_Nullable _){
[self->_flutterApi onSdkInvokeWithCompletion:^(FlutterError *_Nullable _){
}];
};
}
Expand Down Expand Up @@ -141,7 +141,7 @@ - (void)bindOnDismissCallbackWithError:(FlutterError *_Nullable *_Nonnull)error

[self->_flutterApi onSdkDismissDismissType:dismissTypeString
reportType:reportTypeString
completion:^(NSError *_Nullable _){
completion:^(FlutterError *_Nullable _){
}];
};
}
Expand Down
2 changes: 1 addition & 1 deletion ios/Classes/Modules/RepliesApi.m
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ - (void)hasChatsWithCompletion:(nonnull void (^)(NSNumber * _Nullable, FlutterEr

- (void)bindOnNewReplyCallbackWithError:(FlutterError *_Nullable *_Nonnull)error {
IBGReplies.didReceiveReplyHandler = ^{
[self->_flutterApi onNewReplyWithCompletion:^(NSError *_Nullable _){
[self->_flutterApi onNewReplyWithCompletion:^(FlutterError *_Nullable _){
}];
};
}
Expand Down
4 changes: 2 additions & 2 deletions ios/Classes/Modules/SurveysApi.m
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,14 @@ - (void)getAvailableSurveysWithCompletion:(void (^)(NSArray<NSString *> *_Nullab

- (void)bindOnShowSurveyCallbackWithError:(FlutterError *_Nullable *_Nonnull)error {
IBGSurveys.willShowSurveyHandler = ^{
[self->_flutterApi onShowSurveyWithCompletion:^(NSError *_Nullable _){
[self->_flutterApi onShowSurveyWithCompletion:^(FlutterError *_Nullable _){
}];
};
}

- (void)bindOnDismissSurveyCallbackWithError:(FlutterError *_Nullable *_Nonnull)error {
IBGSurveys.didDismissSurveyHandler = ^{
[self->_flutterApi onDismissSurveyWithCompletion:^(NSError *_Nullable _){
[self->_flutterApi onDismissSurveyWithCompletion:^(FlutterError *_Nullable _){
}];
};
}
Expand Down
10 changes: 6 additions & 4 deletions pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
name: instabug_flutter
version: 11.13.0
description: >-
Instabug empowers mobile teams to monitor, prioritize, and debug
performance and stability issues throughout the app development lifecycle.
Instabug empowers mobile teams to monitor, prioritize, and debug
performance and stability issues throughout the app development lifecycle.
homepage: https://www.instabug.com/platforms/flutter
repository: https://github.com/Instabug/Instabug-Flutter
documentation: https://docs.instabug.com/docs/flutter-overview
Expand All @@ -18,9 +18,11 @@ dev_dependencies:
flutter_test:
sdk: flutter
lint: ^1.0.0
mockito: 5.2.0
# mockito v5.2.0 is needed for running Flutter 2 tests on CI
mockito: '>=5.2.0 <=5.4.2'
pana: ^0.21.0
pigeon: ^3.0.0
# pigeon v3.0.0 is needed for running Flutter 2 tests on CI
pigeon: '>=3.0.0 <=10.1.5'

flutter:
plugin:
Expand Down