Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: support multi-dimensional tile configuration. Closes #127. #132

Merged
merged 1 commit into from
Sep 30, 2019

Conversation

dzenanz
Copy link
Member

@dzenanz dzenanz commented Sep 24, 2019

  • Delegate 2D parsing and writing to template nD variants
  • Remove parseRow
  • Update tests to work with new parsing code

3D test has some negative pixels due to non-linear interpolation.
If we cast it to unsigned short, some pixels have maximum brightness.
Therefore add signed short as supported pixel type in the test.

@dzenanz dzenanz force-pushed the master branch 4 times, most recently from 7ef735b to 6c7c535 Compare September 25, 2019 14:41
…wareConsortium#127.

* Delegate 2D parsing and writing to template nD variants
* Remove parseRow
* Update tests to work with new parsing code

3D test has some negative pixels due to non-linear interpolation.
If we cast it to unsigned short, some pixels have maximum brightness.
Therefore add signed short as supported pixel type in the test.
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @dzenanz !

@thewtex thewtex merged commit c2cbbc1 into InsightSoftwareConsortium:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants