Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STYLE: Add ITK prefix to testing macros #999

Merged
merged 1 commit into from
Jun 6, 2019
Merged

STYLE: Add ITK prefix to testing macros #999

merged 1 commit into from
Jun 6, 2019

Conversation

maekclena
Copy link
Contributor

Closes #940.

dzenanz
dzenanz approved these changes Jun 6, 2019
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on consistency!

@hjmjohnson hjmjohnson merged commit dbb1532 into InsightSoftwareConsortium:master Jun 6, 2019
@jhlegarreta jhlegarreta mentioned this pull request Jun 10, 2019
Merged
@dzenanz
Copy link
Member

dzenanz commented Jun 10, 2019

This rename now needs to be done in remote modules too, e.g. C:\Dev\ITK-git\Modules\Remote\Thickness3D\test\itkBinaryThinningImageFilter3DTest.cxx(48,3): error C3861: 'TRY_EXPECT_NO_EXCEPTION': identifier not found

jhlegarreta added a commit to jhlegarreta/ITKSoftwareGuide that referenced this pull request Jun 11, 2019
@jhlegarreta
DOC: Update ITK testing macros names
8ac0357 
Update ITK testing macros names after they were renamed in
InsightSoftwareConsortium/ITK#999
@jhlegarreta jhlegarreta mentioned this pull request Jun 11, 2019
Merged
jhlegarreta added a commit to jhlegarreta/ITK that referenced this pull request Jun 11, 2019
@jhlegarreta
ENH: Add script to update ITK testing macros names
5afdcca 
Add script to update ITK testing macros names.

Motivated by PR InsightSoftwareConsortium#999.

This script should ease the task to update the testing macros names in
remote modules when used together with the
[ApplyScriptToRemotes.sh](https://github.com/InsightSoftwareConsortium/ITK/blob/master/Utilities/Maintenance/ApplyScriptToRemotes.sh)
script.
This was referenced Jun 11, 2019
Merged
Merged
@jhlegarreta
Copy link
Member

A few remotes were updated applying the fixes in #1021 and executing:

./Utilities/Maintenance/ApplyScriptToRemotes.sh
~/src/itk/itk-head/ITK/Utilities/Maintenance/UpdateTestingMacrosNames.sh 
UpdateTestingMacrosNames "STYLE: Add ITK prefix to testing macros"

A few other issues arose (#1024 and #1025) while testing the script. Note that only remotes whose build status is successful are update.

Thanks for your patience.

@jhlegarreta
Copy link
Member

jhlegarreta commented Jun 15, 2019 •
edited
Loading

Just for the sake of completeness, updated remote modules were

So it looks like quite a few have an unsuccessful build status currently.

@jhlegarreta jhlegarreta mentioned this pull request Jul 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjmjohnson hjmjohnson hjmjohnson approved these changes

@dzenanz dzenanz dzenanz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ITK Testing Macros should be prefixed with ITK_
4 participants
@maekclena @dzenanz @jhlegarreta @hjmjohnson