Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Remove VNL Netlib rpoly files #5267

Draft
wants to merge 2 commits into
base: release
Choose a base branch
from
Draft

BUG: Remove VNL Netlib rpoly files #5267

wants to merge 2 commits into from

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Mar 7, 2025

These were added to VNL with the ACM Software License Agreement, which is not commercial-friendly.

We were not using it, explicitly remove it.

@thewtex
BUG: Remove VNL Netlib rpoly files
6894a17 
These were added to VNL with the ACM Software License Agreement, which
is not commercial-friendly.

We were not using it, explicitly remove it.
@thewtex thewtex requested review from hjmjohnson and dzenanz March 7, 2025 23:14
@github-actions github-actions bot added type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots area:ThirdParty Issues affecting the ThirdParty module labels Mar 7, 2025
@N-Dekker
Copy link
Contributor

N-Dekker commented Mar 9, 2025

I see, it says at https://www.acm.org/publications/policies/software-copyright-notice

Any User wishing to make a commercial use of the Software must contact ACM at [email protected] to arrange an appropriate license. Commercial use includes (1) integrating or incorporating all or part of the source code into a product for sale or license by, or on behalf of, User to third parties, or (2) distribution of the binary or source code to third parties for use with a commercial product sold or licensed by, or on behalf of, User.

Revised 6/98

@dzenanz
Copy link
Member

dzenanz commented Mar 10, 2025

Why is clang format check failing?

@thewtex
Copy link
Member Author

thewtex commented Mar 10, 2025

Why is clang format check failing?

This is needed:

InsightSoftwareConsortium/ITKClangFormatLinterAction#17

@thewtex thewtex marked this pull request as draft March 10, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjmjohnson hjmjohnson hjmjohnson approved these changes

@dzenanz dzenanz dzenanz approved these changes

Assignees
No one assigned
Labels
area:ThirdParty Issues affecting the ThirdParty module type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thewtex @N-Dekker @dzenanz @hjmjohnson