Skip to content

Fix AttributeError and signature mangling during construction of SOAP request #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 22, 2021

Conversation

mheuwes
Copy link
Contributor

@mheuwes mheuwes commented Nov 16, 2021

Currently, sending SOAP requests using pysaml2 is near-impossible, because two bugs exist:

  1. IDP.apply_binding for soap without sign=True and a pre-signed Message mangles/destroys the signature by removing the line-ends within the signature.
  2. IDP.apply_binding's implementation of signing using use_soap does not work currently, because instead of node_name, class_name is passed as a parameter to securitycontext.sign_statement, and is raising an AttributeError
    These two bugs are fixed with this PR

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

@c00kiemon5ter c00kiemon5ter changed the title Fixing attributeerror and signature mangling while constructing soap requests Fix AttributeError and signature mangling during construction of SOAP request Nov 16, 2021
@mheuwes mheuwes force-pushed the soap-fixes branch 2 times, most recently from 640fad3 to c95093d Compare November 16, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-release should become part of the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants