Fix AttributeError and signature mangling during construction of SOAP request #834
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, sending SOAP requests using pysaml2 is near-impossible, because two bugs exist:
IDP.apply_binding
for soap withoutsign=True
and a pre-signed Message mangles/destroys the signature by removing the line-ends within the signature.IDP.apply_binding
's implementation of signing usinguse_soap
does not work currently, because instead ofnode_name
,class_name
is passed as a parameter tosecuritycontext.sign_statement
, and is raising anAttributeError
These two bugs are fixed with this PR
All Submissions: