Skip to content

Full symmetric meshed metadata proxy #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrvanes
Copy link
Contributor

@mrvanes mrvanes commented Nov 20, 2017

This pullrequest makes satosa a full symmetric meshed federation hub-n-spoke saml proxy. That means that SP's can connect with mirrored IdP's and IdP's can connect with mirrored SP entityID. Meanwhile, satosa can still inject attributes or block access where or when necessary.

@mrvanes
Copy link
Contributor Author

mrvanes commented Nov 23, 2017

The tests now pass the PR.

@leifj
Copy link
Contributor

leifj commented Nov 23, 2017

I actually thought we had this in a microservice already

@mrvanes
Copy link
Contributor Author

mrvanes commented Nov 23, 2017

I've looked, but couldn't find one that covers our requirements, which one do you mean?

@mrvanes
Copy link
Contributor Author

mrvanes commented Feb 12, 2018

I've been looking at the change and could see a way to refactor get_metadata_desc() for both Front- and Backend saml2 modules. This would however require generificication of the specific sp_/idp_entities variable naming and passing a value to discern between idpsso and spsso(_descriptor). We would win brevity of the code, but completely loose readability (in my opinion) of the function. Is that really what we want?

@hlflanagan
Copy link
Contributor

It would be helpful if this PR was updated with the information requested in the shiny new PR template added to this project. The PR as it stands now does not have a sufficient description around how this works or why it’s built this way.

@mrvanes
Copy link
Contributor Author

mrvanes commented Feb 23, 2018

New tests were added
Old code mistakes have been corrected
Existing tests were modified to cater for earlier mistakes in old code
Changes have been rebased on upstream master
Purpose of PR is creating a hub-n-spoke proxy that mimics full-meshed federation by adding the opposite of SAMLMirrorFrontend, we have extensively discussed this at TIIME
This may not be the best way to implement this, see the PR as a base to start discussing this functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants