Rework cross_validation_time.py #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphs and warnings on the code. More clear explanation on why the crossvalidation with shuffle is no adequate for time series. Correction on the graph by ordering the index Correction to avoid a warning in
ArturoAmorQ
changed the title
ArturoAmorQ
approved these changes
Mar 10, 2025
There was a problem hiding this comment.
Thanks for your contribution @SpiderCoop and sorry for taking so long to review! This is already a big improvement for this notebook. I hope you don't mind me pushing some changes to your PR.
ArturoAmorQ
reviewed
Mar 10, 2025
ArturoAmorQ
reviewed
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #786. This PR:
groupswithTimeSeriesSplit;