Preference Comparisons with Updated AutoResetWrapper #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want me to review this yet, or should I wait for upstream changes in seals? |
|
I'd say we wait for upstream in seals so I can update the |
|
Gotcha |
|
I ran code_checks and format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to do pref comp training with both AutoResetWrapper and corrected terminal observation.
Add a test to check new AutoResetWrapper behavior. This is just the test I wrote for
seals. Not sure if this is the best way to do this. The advantage of leaving that test in here is that if something about the ARW behavior changes upstream, the test will easily notify us.Will keep open and not merge for now, until the AutoResetWrapper changes are upstreamed in
seals(see HumanCompatibleAI/seals#69).