Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core-lightning 25.02 #210080

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

core-lightning 25.02 #210080

wants to merge 1 commit into from

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

@github-actions github-actions bot added rust Rust use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Mar 6, 2025
@cho-m
Copy link
Member

cho-m commented Mar 7, 2025

Looks like upstread added pkg-config lookup for libsodium (ElementsProject/lightning@305c377)

But build script also overrides PKG_CONFIG_PATH at https://github.com/ElementsProject/lightning/blob/v25.02/configure#L16

export PKG_CONFIG_PATH=/opt/homebrew/opt/sqlite/lib/pkgconfig

Which breaks detection:

  checking for libsodium with IETF chacha20 variants... no

@cho-m cho-m added upstream issue An upstream issue report is needed build failure CI fails while building the software 13-arm64 Ventura arm64 is specifically affected 14-arm64 Sonoma arm64 is specifically affected 15-arm64 Sequoia arm64 is specifically affected labels Mar 7, 2025
@botantony
Copy link
Contributor

patch:

  patch do
    url "https://github.com/botantony/lightning/commit/cca721a9f3c5a15f6792b0dc1941959dbd93ac2f.patch?full_index=1"
    sha256 "ee375b92de3d49f4bdf33acf2eb672b693f5806ee418a380e37f3a6a4047c91d"
  end

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added stale No recent activity and removed stale No recent activity labels Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
13-arm64 Ventura arm64 is specifically affected 14-arm64 Sonoma arm64 is specifically affected 15-arm64 Sequoia arm64 is specifically affected build failure CI fails while building the software bump-formula-pr PR was created using `brew bump-formula-pr` rust Rust use is a significant feature of the PR or issue upstream issue An upstream issue report is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants