Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tart: disable on 2025-02-28 #206252

Merged
merged 1 commit into from
Mar 10, 2025
Merged

tart: disable on 2025-02-28 #206252

merged 1 commit into from
Mar 10, 2025

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Feb 1, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Disable date set to 2 years after date of 1.0.0 release which introduced new license. About 5 months after deprecation date.

install-on-request: 29 (30 days), 61 (90 days), 347 (365 days)

Worth discussing whether we should recommend upstream tap or not. We have no alternative and brew install-ing tap can drop-in replace existing tart installation.

@cho-m cho-m added maintainer feedback Additional maintainers' opinions may be needed CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Feb 1, 2025
@github-actions github-actions bot added rust Rust use is a significant feature of the PR or issue swift Swift use is a significant feature of the PR or issue formula disabled Formula disabled macos-only Formula depends on macOS labels Feb 1, 2025
@cho-m cho-m added the automerge-skip `brew pr-automerge` will skip this pull request label Feb 1, 2025
@cho-m cho-m marked this pull request as ready for review February 1, 2025 15:23
@iMichka
Copy link
Member

iMichka commented Feb 1, 2025

We don't recommend other taps outside of our org, for security reasons. Can you remove that?

The rest is ok :)

@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Feb 10, 2025
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Mar 10, 2025
@bevanjkay bevanjkay added this pull request to the merge queue Mar 10, 2025
Merged via the queue into master with commit 3c0d00c Mar 10, 2025
22 checks passed
@bevanjkay bevanjkay deleted the tart-disable branch March 10, 2025 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula disabled Formula disabled macos-only Formula depends on macOS maintainer feedback Additional maintainers' opinions may be needed rust Rust use is a significant feature of the PR or issue stale No recent activity swift Swift use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants