Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multipass 1.14.0 #180538

Merged
merged 1 commit into from
Jul 30, 2024
Merged

multipass 1.14.0 #180538

merged 1 commit into from
Jul 30, 2024

Conversation

khipp
Copy link
Member

@khipp khipp commented Jul 24, 2024

Created by brew bump

Created with brew bump-cask-pr.

@BrewTestBot BrewTestBot added the bump-cask-pr PR was created using `brew bump-cask-pr` label Jul 24, 2024
@chenrui333
Copy link
Member

/rebase

@chenrui333 chenrui333 force-pushed the bump-multipass-1.14.0 branch from 3ccf146 to c9fae5e Compare July 24, 2024 19:41
@khipp khipp force-pushed the bump-multipass-1.14.0 branch from c9fae5e to 4a18f48 Compare July 24, 2024 23:22
@khipp
Copy link
Member Author

khipp commented Jul 25, 2024

The application installs and runs without issues on my M1. Were there changes to the CI between the last two versions that could be related?

I will create an issue in the upstream repository tomorrow.

@cho-m
Copy link
Member

cho-m commented Jul 25, 2024

It sounds like the installer has been checking for kern.hv_support for a while (e.g. canonical/multipass#1397).

However, Hypervisor.framework isn't supported on GitHub runner (e.g. actions/runner-images#9460).

@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale Issue which has not received any feedback for some time. label Jul 28, 2024
@ZelnickB
Copy link

Can someone with permission please add the in progress tag so that this doesn't get closed?

@github-actions github-actions bot removed stale Issue which has not received any feedback for some time. labels Jul 28, 2024
@p-linnane p-linnane requested a review from a team July 28, 2024 16:33
@p-linnane p-linnane added awaiting maintainer feedback Issue needs response from a maintainer. help wanted labels Jul 28, 2024
@krehel
Copy link
Member

krehel commented Jul 30, 2024

Fine to ✅ this as I don't think the CI issues are going to be resolved anytime soon, nor are they ours to fix.

@bevanjkay bevanjkay added the ci-skip-install Skip installation on CI. Use only when no fix can be found. label Jul 30, 2024
@khipp khipp force-pushed the bump-multipass-1.14.0 branch from 4a18f48 to af3e715 Compare July 30, 2024 14:48
@p-linnane p-linnane removed awaiting maintainer feedback Issue needs response from a maintainer. help wanted labels Jul 30, 2024
@p-linnane p-linnane merged commit 8a36efc into master Jul 30, 2024
8 checks passed
@p-linnane p-linnane deleted the bump-multipass-1.14.0 branch July 30, 2024 15:15
@khipp khipp mentioned this pull request Jul 30, 2024
Closed
6 tasks
@vsarunas vsarunas mentioned this pull request Oct 18, 2024
Merged
@zyoshoka zyoshoka mentioned this pull request Dec 11, 2024
Merged
@khipp khipp mentioned this pull request Feb 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bevanjkay bevanjkay bevanjkay approved these changes

@p-linnane p-linnane p-linnane approved these changes

Assignees
No one assigned
Labels
bump-cask-pr PR was created using `brew bump-cask-pr` ci-skip-install Skip installation on CI. Use only when no fix can be found.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@khipp @chenrui333 @cho-m @ZelnickB @krehel @bevanjkay @p-linnane @BrewTestBot