Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate elapsed third #1853

Merged
merged 2 commits into from
May 14, 2016
Merged

Calculate elapsed third #1853

merged 2 commits into from
May 14, 2016

Conversation

MSGhero
Copy link
Member

@MSGhero MSGhero commented May 13, 2016

#1836

So that preUpdate signals can have the current elapsed.

@Gama11
Copy link
Member

Gama11 commented May 13, 2016

Hm.. while we're at it, this code should probably be moved into a separate function. ;)

Also, I thought you were gonna implemnet Joe's suggestion (i.e. just swap with the preUpdate signal dispatch), not yours?

@MSGhero
Copy link
Member Author

MSGhero commented May 13, 2016

Separate function within FlxGame? And I honestly didn't think about where I placed it when I dragged the code up. Would you rather it go below ticks and above preUpdate?

Edit: publically exposed?

@Gama11
Copy link
Member

Gama11 commented May 13, 2016

Yeah, less chance to break things if the change is smaller I guess.

No, just a private method (updateElapsed() I guess?).

@MSGhero MSGhero changed the title Calculate elapsed first Calculate elapsed third May 13, 2016
@Gama11
Copy link
Member

Gama11 commented May 14, 2016

Thanks! 👍

@Gama11 Gama11 merged commit b9b330e into HaxeFlixel:dev May 14, 2016
@MSGhero MSGhero deleted the patch-1 branch May 14, 2016 07:26
Aurel300 pushed a commit to larsiusprime/haxeflixel that referenced this pull request Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants