[Fix] CVarClear when Enabled Tricks and Excluded Locations are empty #3916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ricks tabs to get around issue with saving blank CVar strings.
Archez
approved these changes
Feb 6, 2024
|
switch build should pass once we get #3917 in |
briaguya-ai
approved these changes
Feb 6, 2024
garrettjoecox
approved these changes
Feb 12, 2024
garrettjoecox
merged commit 11a0a00
into
HarbourMasters:develop-macready
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the limitation of CVarSetString not saving blank strings, going from any inclusion in those two lists to a blank list (whether by "Disable All" or manually clearing the last one in the list) wouldn't save, and would then return next time the game was restarted. This PR adds CVarClear for those CVars in appropriate locations to make empty lists properly save.
Build Artifacts