Fix (Some of) Actor uncullZone Range Issues (MacReady) #3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inspectredc
changed the title
leggettc18
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still sense that there are some issues with actor cull zones even with this, but this definitely fixes passing the gerudo guard. I'd know about these floats being wrong for a while but had always tested with blue warp zones which are harder to test with and more inconsistent in general so was glad to see it at least fixed the guard.
Edit: King Zora Unfreeze After Moving with Sign works with n64 setups now too
I still need to test that this will look good with widescreen, but I also figure we have disable draw distance for that reason
Edit: Haven't noticed any issues!
soh.otr.zip
soh-linux-compatibility.zip
soh-linux-performance.zip
soh-mac.zip
soh-switch.zip
soh-wiiu.zip
soh-windows.zip