Add OnActorKill & OnEnemyDefeat hooks

[Pepe20129]

Adds the OnActorKill & OnEnemyDefeat hooks.
Also moves the "Enemies Defeated" stats to mods.cpp

Build Artifacts

• soh.otr.zip
• soh-linux-compatibility.zip
• soh-linux-performance.zip
• soh-mac.zip
• soh-switch.zip
• soh-wiiu.zip
• soh-windows.zip

[briaguya-ai]

is this bringing things in line with how it was actually working before or changing the meaning?

was it

COUNT_ENEMIES_DEFEATED_POE means "non-big poes defeated" and COUNT_ENEMIES_DEFEATED_POE_BIG means "big poes defeated" before, and this is changing it to mean COUNT_ENEMIES_DEFEATED_POE meaning "big and non-big poes defeated" and COUNT_ENEMIES_DEFEATED_POE_BIG meaning "big poes defeated"

or was it always

COUNT_ENEMIES_DEFEATED_POE meaning "big and non-big poes defeated" and COUNT_ENEMIES_DEFEATED_POE_BIG meaning "big poes defeated"

[Pepe20129]

COUNT_ENEMIES_DEFEATED_POE means "non-big poes defeated" but ACTOR_EN_PO_FIELD is used by every poe in hyrule field, even the small ones, I just updated the comment to reflect that.

Here's the code for counting the kills:

case ACTOR_EN_POH:
    if (actor->params == EN_POH_FLAT || actor->params == EN_POH_SHARP) {
        gSaveContext.sohStats.count[COUNT_ENEMIES_DEFEATED_POE_COMPOSER]++;
    } else {
        gSaveContext.sohStats.count[COUNT_ENEMIES_DEFEATED_POE]++;
    }
    break;

case ACTOR_EN_PO_FIELD:
    if (actor->params == EN_PO_FIELD_BIG) {
        gSaveContext.sohStats.count[COUNT_ENEMIES_DEFEATED_POE_BIG]++;
    } else {
        gSaveContext.sohStats.count[COUNT_ENEMIES_DEFEATED_POE]++;
    }
    break;

[garrettjoecox]

@Pepe20129 not sure if you saw but the builds here failed

[Pepe20129]

The only change in the commit that has broken builds is the removal of comments so it shouldn't have failed. I have made an empty commit to re-run the build.

[Pepe20129]

It turns out that the first commit didn't run any builds even though it displays a checkmark.
The problem was that in non-windows platforms the missing include statements were causing the build to fail.

[garrettjoecox]

Looks like you need to resolve a conflict but otherwise LGTM

[Pepe20129]

Fixed the confict.