Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

122 sbatch #125

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

122 sbatch #125

wants to merge 4 commits into from

Conversation

abhidg
Copy link
Contributor

@abhidg abhidg commented Mar 4, 2025

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 81.08108% with 7 lines in your changes missing coverage. Please review.

Project coverage is 87.25%. Comparing base (81d44d0) to head (5f2831a).

Files with missing lines Patch % Lines
cats/__init__.py 56.25% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   87.20%   87.25%   +0.05%     
==========================================
  Files          14       14              
  Lines         586      612      +26     
==========================================
+ Hits          511      534      +23     
- Misses         75       78       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@andreww andreww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks okay to me. Has it been tested in reality on a system running slurm?

abhidg added 2 commits March 8, 2025 10:55
Make schedule_at() signature same as schedule_batch(). Side effects are
handled by mocking.
@sadielbartholomew
Copy link
Member

@abhidg do you need a second review or is one sufficient?

@abhidg
Copy link
Contributor Author

abhidg commented Mar 10, 2025

@sadielbartholomew could you check if this PR works in a cluster? I don't have an account on our supercomputer ATM.

@sadielbartholomew
Copy link
Member

could you check if this PR works in a cluster? I don't have an account on our supercomputer ATM.

Sure, as long as you don't mind waiting a couple of days - I have some urgent work to sort for tomorrow and it will take a bit more time to review on JASMIN or ARCHER2. Will aim to submit a cluster-based review by the end of the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scheduler: add sbatch
3 participants