-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
122 sbatch #125
base: main
Are you sure you want to change the base?
122 sbatch #125
Conversation
abhidg
commented
Mar 4, 2025
- ci: update pre-commit hooks
- feat: add sbatch scheduler support, fixes scheduler: add sbatch #122
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
+ Coverage 87.20% 87.25% +0.05%
==========================================
Files 14 14
Lines 586 612 +26
==========================================
+ Hits 511 534 +23
- Misses 75 78 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks okay to me. Has it been tested in reality on a system running slurm?
Make schedule_at() signature same as schedule_batch(). Side effects are handled by mocking.
@abhidg do you need a second review or is one sufficient? |
@sadielbartholomew could you check if this PR works in a cluster? I don't have an account on our supercomputer ATM. |
Sure, as long as you don't mind waiting a couple of days - I have some urgent work to sort for tomorrow and it will take a bit more time to review on JASMIN or ARCHER2. Will aim to submit a cluster-based review by the end of the week. |