Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade godotenv. #9738

Closed
wants to merge 1 commit into from

Conversation

plumpy
Copy link
Collaborator

@plumpy plumpy commented Feb 26, 2025

godotenv 1.5 only allows environment variable names containing [A-Za-z0-9_.]. This is different than 1.4, which allowed almost any character.

@plumpy plumpy requested a review from a team as a code owner February 26, 2025 05:12
@plumpy plumpy force-pushed the downgrade_godotenv branch from 097e9e7 to cc901b2 Compare February 26, 2025 05:13
@Darien-Lin
Copy link
Contributor

Darien-Lin commented Feb 26, 2025

Was this bumped up b/c of vulnerabilities? if so, we should probably open an issue on that package's github about the restriction?

joho/godotenv#211 seems that there is an issue similar to our usage

Darien-Lin
Darien-Lin previously approved these changes Feb 26, 2025
godotenv 1.5 only allows environment variable names containing `[A-Za-z0-9_.]`.
This is different than 1.4, which allowed almost any character.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants