fix: CheckPushPermissions not being called when CacheRepo was set (#1471

)
GoogleContainerTools · Oct 30, 2020 · 2f8d939 · 2f8d939
1 parent 5afb142
commit 2f8d939
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/cmd/executor/cmd/root.go b/cmd/executor/cmd/root.go
@@ -95,7 +95,7 @@ var RootCmd = &cobra.Command{
 			}
 			logrus.Warn("kaniko is being run outside of a container. This can have dangerous effects on your system")
 		}
-		if !opts.NoPush {
+		if !opts.NoPush || opts.CacheRepo != "" {
 			if err := executor.CheckPushPermissions(opts); err != nil {
 				exit(errors.Wrap(err, "error checking push permissions -- make sure you entered the correct tag name, and that you are authenticated correctly, and try again"))
 			}

diff --git a/pkg/executor/push.go b/pkg/executor/push.go
@@ -102,7 +102,7 @@ var (
 // CheckPushPermissions checks that the configured credentials can be used to
 // push to every specified destination.
 func CheckPushPermissions(opts *config.KanikoOptions) error {
-	var targets = opts.Destinations
+	targets := opts.Destinations
 	// When no push is set, whe want to check permissions for the cache repo
 	// instead of the destinations
 	if opts.NoPush {