Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds control to push tags on existing images in target registry #2382

Closed
wants to merge 3 commits into from
Closed

Conversation

karlmuscat
Copy link
Contributor

Relevant issues: #2360

Currently Jib pushes tags for all built images, irrelevant of whether the image is already
present on the target registry.

As highlighted by @loosebazooka #2360
this can be particularly annoying if some automated orchestrator is monitoring the registry
and releases any new tags found. This issue is especially prevalent in cases where the tags are
auto-generated by CI systems and added with every triggered build.

The idea is to give the user the ability to control this functionality by means of a switch/option.
There might be use-cases where the current behaviour is preferable, eg, where the tags follow semantic
versioning, or where the tags are not automatically generated. Hence, adding a switch seems to be
a better solution rather than changing the current behaviour.

@googlebot

This comment has been minimized.

@karlmuscat

This comment has been minimized.

@googlebot

This comment has been minimized.

@loosebazooka
Copy link
Member

Hey @karlmuscat usually for a change like this, we start off with just the proposal, and work on that before adding code. Sorry if my instructions were unclear. As there is some cost to adding and removing configuration, we need to review the design first before doing any coding work.

@karlmuscat
Copy link
Contributor Author

@loosebazooka no problem at all. Do you need me to add some more detail to this PR to get the discussion going?

@loosebazooka
Copy link
Member

@karlmuscat yes, can you create a new PR (you can leave this open) with just the design proposal?

@karlmuscat
Copy link
Contributor Author

@loosebazooka Created new PR. Ill close this one to avoid confusion.

@karlmuscat karlmuscat closed this Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants