Update changelog for json image metadata file #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanseokoh
reviewed
Jan 21, 2020
jib-gradle-plugin/CHANGELOG.md
Outdated
| @@ -5,6 +5,8 @@ All notable changes to this project will be documented in this file. | |||
|
|
|||
| ### Added | |||
|
|
|||
| - Added json output to file of image reference information after build. Defaults to `build/jib-image.json`, configurable with `jib.outputPaths.imageJson`. ([#2227](https://github.com/GoogleContainerTools/jib/pull/2227)) | |||
There was a problem hiding this comment.
I can't parse this.
I didn't look into the PR. Does the JSON record only the image reference? And no tags?
There was a problem hiding this comment.
no, my wording is awful, lemme fix this whole thing.
TadCordle
reviewed
Jan 21, 2020
jib-gradle-plugin/CHANGELOG.md
Outdated
| @@ -5,6 +5,8 @@ All notable changes to this project will be documented in this file. | |||
|
|
|||
| ### Added | |||
|
|
|||
| - Added json output to file of image reference information after build. Defaults to `build/jib-image.json`, configurable with `jib.outputPaths.imageJson`. ([#2227](https://github.com/GoogleContainerTools/jib/pull/2227)) | |||
There was a problem hiding this comment.
This might help?
Suggested change
| - Added json output to file of image reference information after build. Defaults to `build/jib-image.json`, configurable with `jib.outputPaths.imageJson`. ([#2227](https://github.com/GoogleContainerTools/jib/pull/2227)) | |
| - Added json output of image reference information to file after build. Defaults to `build/jib-image.json`, configurable with `jib.outputPaths.imageJson`. ([#2227](https://github.com/GoogleContainerTools/jib/pull/2227)) |
|
I'll add the updates to README in another PR. |
|
Actually looks likes the contributor includes those changes in the README already. |
chanseokoh
approved these changes
Jan 21, 2020
jib-maven-plugin/CHANGELOG.md
Outdated
| @@ -5,6 +5,8 @@ All notable changes to this project will be documented in this file. | |||
|
|
|||
| ### Added | |||
|
|
|||
| - Added json output file for image metadata after a build is complete. Writes to `target/jib-image.json` by default, configurable with `jib.outputPaths.imageJson`. ([#2227](https://github.com/GoogleContainerTools/jib/pull/2227)) | |||
There was a problem hiding this comment.
For Maven, we do <outputPaths><imageJson>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog for #2227