Skip to content
This repository was archived by the owner on Jan 9, 2023. It is now read-only.

Remove reference to standalone cobra cli #40

Closed
wants to merge 1 commit into from
Closed

Remove reference to standalone cobra cli #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/src/kafka-pubsub-emulator-gateway/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ clean() {
}

build_proto_files(){
go get -u -v github.com/spf13/cobra/cobra && \
go get -u -v github.com/spf13/cobra && \
Copy link

@jpmcb jpmcb Mar 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be

-  go get -u -v github.com/spf13/cobra/cobra && \
+  go get -u -v github.com/spf13/cobra-cli && \

?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. From what I can tell, this is trying to fetch the dependencies needed to compile, and that is only the cobra lib. It just happened to fetch the parent lib as a side effect before

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is trying to fetch the dependencies needed to compile

Ah that makes sense 👍🏼

go get -u -v google.golang.org/grpc && \
go get -u -v github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway && \
go get -u -v github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger && \
Expand Down