Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: attempt RenderDocument experiment #16363

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

paulirish
Copy link
Member

@paulirish paulirish commented Mar 3, 2025

Much like puppeteer/puppeteer#13176 this is to evaluate CI failures with RenderDocument enabled.


dbw is failing
  ✘ difference at geolocation-on-start audit.score
              expected: 0
                 found: 1

#           found result:
      {
        "id": "geolocation-on-start",
        "title": "Avoids requesting the geolocation permission on page load",
        "description": "Users are mistrustful of or confused by sites that request their location without context. Consider tying the request to a user action instead. [Learn more about the geolocation permission](https://developer.chrome.com/docs/lighthouse/best-practices/geolocation-on-start/).",
        "score": 1,
        "scoreDisplayMode": "binary",
        "details": {
          "type": "table",
          "headings": [],
          "items": []
        }
      }
  
# 
  ✘ difference at no-document-write audit.score
              expected: 0.5
                 found: 1

# 
  ✘ difference at no-document-write audit.details.items.length
              expected: 3
                 found: 0

#           found result:
      {
        "id": "no-document-write",
        "title": "Avoids `document.write()`",
        "description": "For users on slow connections, external scripts dynamically injected via `document.write()` can delay page load by tens of seconds. [Learn how to avoid document.write()](https://developer.chrome.com/docs/lighthouse/best-practices/no-document-write/).",
        "score": 1,
        "scoreDisplayMode": "metricSavings",
        "details": {
          "type": "table",
          "headings": [],
          "items": []
        },
        "guidanceLevel": 2
      }
  
# 
  ✘ difference at notification-on-start audit.score
              expected: 0
                 found: 1

#           found result:
      {
        "id": "notification-on-start",
        "title": "Avoids requesting the notification permission on page load",
        "description": "Users are mistrustful of or confused by sites that request to send notifications without context. Consider tying the request to user gestures instead. [Learn more about responsibly getting permission for notifications](https://developer.chrome.com/docs/lighthouse/best-practices/notification-on-start/).",
        "score": 1,
        "scoreDisplayMode": "binary",
        "details": {
          "type": "table",
          "headings": [],
          "items": []
        }
      }
  
#   ✓ render-blocking-resources audit
# 
  ✘ difference at uses-passive-event-listeners audit.score
              expected: 0.5
                 found: 1

# 
  ✘ difference at uses-passive-event-listeners audit.details.items.length
              expected: ">=1"
                 found: 0

#           found result:
      {
        "id": "uses-passive-event-listeners",
        "title": "Uses passive listeners to improve scrolling performance",
        "description": "Consider marking your touch and wheel event listeners as `passive` to improve your page's scroll performance. [Learn more about adopting passive event listeners](https://developer.chrome.com/docs/lighthouse/best-practices/uses-passive-event-listeners/).",
        "score": 1,
        "scoreDisplayMode": "metricSavings",
        "details": {
          "type": "table",
          "headings": [],
          "items": []
        },
        "guidanceLevel": 3
      }

@paulirish paulirish requested a review from a team as a code owner March 3, 2025 19:22
@paulirish paulirish requested review from connorjclark and removed request for a team March 3, 2025 19:22
@connorjclark connorjclark marked this pull request as draft March 4, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant