Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename dingo to dingo_walk #111

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

vfisikop
Copy link
Contributor

This is needed for creating a pip package (since the dingo name is already used).

@vfisikop vfisikop requested review from TolisChal and hariszaf March 11, 2025 20:55
@hariszaf
Copy link
Collaborator

Hi @vfisikop !
Having dingo on PyPi would be great 🎉 and dingo_walk is just fine.
However, I do not think that we need to change the namespace all over the project.
It's possible to have something like

pip install dingo_walk

and then

import dingo
..

If there is not a reason I am not aware of to change the namespace all over, I would suggest to go with the above solution.

@vfisikop
Copy link
Contributor Author

I proposed that change since I think it is more clear to have a unique name everywhere (namespace, package etc). Also since there is a package named dingo already (that has also the same name for its namespace) there is a conflict.

@hariszaf
Copy link
Collaborator

I have no strong opinion on this, I just really enjoyed the sklearn story when I first heard of it. 👨‍💻

@vfisikop
Copy link
Contributor Author

@TolisChal what is your opinion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants