Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X-CKAN-API-Key as apitoken_header_name #813

Merged
merged 2 commits into from
Feb 14, 2025
Merged

X-CKAN-API-Key as apitoken_header_name #813

merged 2 commits into from
Feb 14, 2025

Conversation

FuhuXia
Copy link
Member

@FuhuXia FuhuXia commented Feb 14, 2025

Pull Request

Related to GSA/data.gov#5085

About

Authorization does not work. X-CKAN-API-Key works.

PR TASKS

  • The actual code changes.
  • Tests written and passed.
  • Any changes to docs?
  • Any new
    requirements versions
    to pull in?

neilmb
neilmb previously approved these changes Feb 14, 2025
Copy link

@neilmb neilmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see this as a fix, but still curious why it was/wasn't working in other environments.

@FuhuXia
Copy link
Member Author

FuhuXia commented Feb 14, 2025

Glad to see this as a fix, but still curious why it was/wasn't working in other environments.

It is a question for cloud.gov. Maybe they did something different for prod and staging spaces?

cmhedrickREI
cmhedrickREI previously approved these changes Feb 14, 2025
btylerburton
btylerburton previously approved these changes Feb 14, 2025
@btylerburton
Copy link
Contributor

Yeah, they probably pass all tokens in the lowers and lock down prod.

@FuhuXia FuhuXia dismissed stale reviews from btylerburton, cmhedrickREI, and neilmb via 66780c5 February 14, 2025 20:32
@FuhuXia FuhuXia merged commit 30461f0 into main Feb 14, 2025
6 checks passed
@FuhuXia FuhuXia deleted the apitoken-name branch February 14, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants