Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep session live for active user #811

Merged
merged 1 commit into from
Feb 12, 2025
Merged

keep session live for active user #811

merged 1 commit into from
Feb 12, 2025

Conversation

FuhuXia
Copy link
Member

@FuhuXia FuhuXia commented Feb 12, 2025

Pull Request

Related to GSA/data.gov#5079 (comment)

About

Expected session behavior:

  • Session should not end for active user
  • Session ends when user idles for 15 mins
  • Session ends when browser is close

After CKAN 2.11, the sessions handling has been refactored, dropping the Beaker library in favour of Flask-Session.

PR TASKS

  • The actual code changes.
  • Tests written and passed.
  • Any changes to docs?
  • Any new
    requirements versions
    to pull in?

@FuhuXia FuhuXia requested a review from a team February 12, 2025 19:53
@FuhuXia FuhuXia mentioned this pull request Feb 12, 2025
14 tasks
Copy link
Contributor

@btylerburton btylerburton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FuhuXia FuhuXia merged commit 336e976 into main Feb 12, 2025
11 checks passed
@FuhuXia FuhuXia deleted the flask-session branch February 12, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants